场景:一个异步重算功能(任务新建后发送消息到RocketMq),每次重算单条记录的时候,可以计算正确,但是当多条记录批量重算时,结果总是莫名其妙的不对。排查了很久,终于找到原因
原因:在新建重算任务方法上添加了事务注解,而发送消息也在该方法中,导致事务未提交,消息已经发出去了。
源代码:
@Transactional public void updateGiftCostByTradeList(ShopShard shopShard, List<Trade> tradeList) { Preconditions.checkArgument(null != shopShard && !CollectionUtils.isEmpty(tradeList)); for (Trade trade : tradeList) { if (TradeSpecialTypeEnum.getSpecialTypes().contains(trade.getTradeSpecialType())) { continue; } long giftCost = getGiftCostFromZhanggui(shopShard.getShopId(), trade); giftCost = giftCost > 0 ? giftCost : getGiftCostFromCaiwu(shopShard.getShopId(), trade); if ((trade.getGiftFee() == null ? 0 : trade.getGiftFee()) == giftCost) { continue; } tradeService.updateTradeGiftFee(shopShard.getShopId(), trade.getId(), giftCost); SendMsgToMqUtil.sendTradeMsgToTradeFeeTopic(rocketMqProducer, shopShard, trade); } }
更改后:
@Transactional public void updateGiftCostByTradeList(ShopShard shopShard, List<Trade> tradeList) { Preconditions.checkArgument(null != shopShard && !CollectionUtils.isEmpty(tradeList)); for (Trade trade : tradeList) { if (TradeSpecialTypeEnum.getSpecialTypes().contains(trade.getTradeSpecialType())) { continue; } long giftCost = getGiftCostFromZhanggui(shopShard.getShopId(), trade); giftCost = giftCost > 0 ? giftCost : getGiftCostFromCaiwu(shopShard.getShopId(), trade); if ((trade.getGiftFee() == null ? 0 : trade.getGiftFee()) == giftCost) { continue; } tradeService.updateTradeGiftFee(shopShard.getShopId(), trade.getId(), giftCost); } } private void doProcessCostRule(ShopShard shopShard, CostRule costRule) {
commonCostRuleService.updateGiftCostByTradeList(shopShard, pageInfo.getList());
pageInfo.getList().forEach(trade -> {
if (!recalStatPoolCommonServcie.sendMqToRecalStatPoolByTrade(trade, TradeStatRecalSourceEnum.GIFT_COST)) {
log.error("process costRule trade send recalstatpool false shopId={}|trade={}", shopShard.getShopId(), JSON.toJSONString(trade));
}
});
}