代码复审作业

我在结对编程的partner是程刚（博客 cnblogs.com/a1071986199/），以下是我对其个人项目（词频统计）的复审结果。

partner是用c++写的，只包含一个文件，是面向过程的程序。

代码写得好的地方：

一、程序流程较清晰。

二、变量命名能做到顾名思义。

代码存在的问题：

一、模块化设计不合理。

程序主要模块分为3个：main——交互；DirectoryList——扫描所有文件，并统计所有单词；Output——对单词进行排序，并输出结果

问题有：

1. DirectoryList实现的功能太多，模块庞大，难以维护。

2. Output包含了附加功能——排序，而这个单独作为一个模块会更好。

二、代码冗余度高

1. Output模块共设计了3个，分别对应3种模式。它们除了参数中泛型类型参数不同之外，代码几乎一样。

2. 在DirectoryList函数中，对于flag（即模式）的3个分支太多冗余代码。

进行重构是一个很好的选择。

三、代码重用度低

1. 在DirectoryList中的参数，为3个模式分别设置了3个vector参数。不仅其中两个参数将会变成打酱油的（取决于另一个参数flag），而且，如果需求变动（增加或减少模式），改动代价将会很大。

2. DirectoryList内置文件后缀名的筛选。如果需求变动，那么很难发现需要更改的地方。将其设置为接口会更好。

四、算法复杂度高

建立单词表时，每新增一个单词就要与单词表中所有项进行比较，效率太低。建议是以单词的小写形式为索引，维护一个有序表，这样在查找或更改时可以利用二分法缩短时间。

附上partner的源代码：

// ConsoleApplication1.cpp : 定义控制台应用程序的入口点。
//

#include "stdafx.h"
#include <windows.h>
#include <string>
#include <fstream>
#include <vector>
#include <cstring>
#include <iostream>
#include <algorithm>
using namespace std;

#define LEN 1024

BOOL Is_Letter(char c)
{
    if ((c >= 'A' && c <= 'Z' )||( c<='z' && c >= 'a')) return true;
    else return false;
}

BOOL Is_Number(char c)
{
    if (c >= '0'&&c <= '9') return true;
    else return false;
}

BOOL Is_OneWord(char letter[],string vec_word)
{
    string Letter = letter;
    transform(Letter.begin(), Letter.end(), Letter.begin(), toupper);
    transform(vec_word.begin(), vec_word.end(), vec_word.begin(), toupper);
    if (Letter == vec_word) return true;
    else return false;
}
struct one
{
    string word;
    int num;
};
struct two
{
    string word1;
    string word2;
    int num;
};
struct three
{
    string word1;
    string word2;
    string word3;
    int num;
};
void One_Output(vector<one> *vec1)
{
    int i, j, size;
    size = (*vec1).size();
    one temp;
    for (i = 0; i < size; i++)
    {
        int index = i;
        for (j = i; j < size; j++)
        {
            if (((*vec1)[index].num < (*vec1)[j].num) || ((*vec1)[index].num == (*vec1)[j].num&&
                (*vec1)[index].word>(*vec1)[j].word)) index = j;
        }
        if (i != index)
        {
            temp.word = (*vec1)[i].word;
            temp.num = (*vec1)[i].num;
            (*vec1)[i].word = (*vec1)[index].word;
            (*vec1)[i].num = (*vec1)[index].num;
            (*vec1)[index].word = temp.word;
            (*vec1)[index].num = temp.num;
        }
    }

    ofstream fout("程刚.txt", ios::out);
    size = (*vec1).size();
    for (i = 0; i < size; i++)
        fout << (*vec1)[i].word << ": " << (*vec1)[i].num << endl;
    cout << "程序结束" << endl;
}
void Two_Output(vector<two> *vec1)
{
    int i, j, size;
    size = (*vec1).size();
    two temp;
    for (i = 0; i < size; i++)
    {
        int index = i;
        for (j = i; j < size; j++)
        {
            if ( (*vec1)[index].num < (*vec1)[j].num || ((*vec1)[index].num == (*vec1)[j].num &&
                 (*vec1)[index].word1>(*vec1)[j].word1) || ((*vec1)[index].num == (*vec1)[j].num && 
                 (*vec1)[index].word1 == (*vec1)[j].word1) && ((*vec1)[index].word2 >(*vec1)[j].word2) )
                 index = j;
        }
        if (i != index)
        {
            temp.word1 = (*vec1)[i].word1;
            temp.word2 = (*vec1)[i].word2;
            temp.num = (*vec1)[i].num;
            (*vec1)[i].word1 = (*vec1)[index].word1;
            (*vec1)[i].word2 = (*vec1)[index].word2;
            (*vec1)[i].num = (*vec1)[index].num;
            (*vec1)[index].word1 = temp.word1;
            (*vec1)[index].word2 = temp.word2;
            (*vec1)[index].num = temp.num;
        }
    }

    ofstream fout("程刚.txt", ios::out);
    size = (*vec1).size();
    for (i = 0; i < size && i < 10; i++)
        fout <<  (*vec1)[i].word1 << " " << (*vec1)[i].word2 << ": " << (*vec1)[i].num << endl;
    cout << "程序结束" << endl;
}
void Three_Output(vector<three> *vec1)
{
    int i, j, size;
    size = (*vec1).size();
    three temp;
    for (i = 0; i < size ; i++)
    {
        int index = i;
        for (j = i; j < size; j++)
        {
            if (((*vec1)[index].num < (*vec1)[j].num) || 
                ((*vec1)[index].num == (*vec1)[j].num &&(*vec1)[index].word1>(*vec1)[j].word1) || 
                ((*vec1)[index].num == (*vec1)[j].num && ((*vec1)[index].word1 == (*vec1)[j].word1) && (*vec1)[index].word2 >(*vec1)[j].word2) || 
                ((*vec1)[index].word1 == (*vec1)[j].word1) && (*vec1)[index].word2 == (*vec1)[j].word2 && (*vec1)[index].word3 >(*vec1)[j].word3)
                index = j;
            
        }
        if (i != index)
        {
            temp.word1 = (*vec1)[i].word1;
            temp.word2 = (*vec1)[i].word2;
            temp.word3 = (*vec1)[i].word3;
            temp.num = (*vec1)[i].num;
            (*vec1)[i].word1= (*vec1)[index].word1;
            (*vec1)[i].word2 = (*vec1)[index].word2;
            (*vec1)[i].word3 = (*vec1)[index].word3;
            (*vec1)[i].num = (*vec1)[index].num;
            (*vec1)[index].word1 = temp.word1;
            (*vec1)[index].word2 = temp.word2;
            (*vec1)[index].word3 = temp.word3;
            (*vec1)[index].num = temp.num;
        }
    }

    ofstream fout("程刚.txt", ios::out);
    size = (*vec1).size();
    for (i = 0; i < size && i < 10; i++)
        fout <<  (*vec1)[i].word1 << " "<<(*vec1)[i].word2 <<(*vec1)[i].word3 << ": " << (*vec1)[i].num << endl;
    cout << "程序结束" << endl;
}
// 深度优先递归遍历目录中所有的文件,参考网上代码
int  DirectoryList(LPCSTR Path, int flag, vector<one> *key1, vector<two> *key2, vector<three> *key3)
{
    WIN32_FIND_DATA FindData;
    HANDLE hError;
    char FilePathName[LEN];
    // 构造路径
    char FullPathName[LEN];
    strcpy_s(FilePathName, Path);
    strcat_s(FilePathName, "\*.*");
    hError = FindFirstFile(FilePathName, &FindData);
    if (hError == INVALID_HANDLE_VALUE)
    {
        printf("搜索失败!");
        return 0;
    }
    while (::FindNextFile(hError, &FindData))
    {
        // 过虑.和..
        if (strcmp(FindData.cFileName, ".") == 0
            || strcmp(FindData.cFileName, "..") == 0)
        {
            continue;
        }

        // 构造完整路径
        wsprintf(FullPathName, "%s\%s", Path, FindData.cFileName);
        // 输出本级的文件
        printf("
 %s  ", FullPathName);

        if (FindData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)
        {
            printf("<Dir>");
            DirectoryList(FullPathName,flag,key1,key2,key3);
        }
        char *suffix;
        suffix = strrchr(FullPathName, '.');
        if (suffix==0) continue;
        //如果是.txt、.cpp、.cs、.h结尾的文件后缀，进行文件读取和词频统计
        if (strcmp(suffix, ".txt") ==0|| strcmp(suffix, ".cpp")==0 || strcmp(suffix, ".cs")==0 || strcmp(suffix, ".h")==0)
        {
            if (flag == 1) 
            {
                ifstream in(FullPathName);
                char c;
                int CharacterFlag = 0;
                int LetterCount = 0;
                char Letter[LEN];
                int i;
                one temp;
                while (!in.eof())
                {
                    c = in.get();
                    if (Is_Letter(c)) { Letter[LetterCount] = c; LetterCount++; }
                    else if (Is_Number(c) && LetterCount >= 3)  {
                        CharacterFlag = 1;
                        Letter[LetterCount] = c; LetterCount++;
                    }
                    else if (!Is_Letter(c) && !Is_Number(c) && (CharacterFlag == 1 || LetterCount >= 3))
                    {
                        Letter[LetterCount] = '';
                        for (i = 0; i < int((*key1).size()); i++)
                        {
                            if (Is_OneWord(Letter, (*key1)[i].word)) {
                                if (Letter < (*key1)[i].word) (*key1)[i].word = Letter;
                                (*key1)[i].num++; break;
                            }
                        }
                        if ((*key1).size() == 0 || i == (*key1).size()) {
                            temp.word = Letter; temp.num = 1;
                            (*key1).push_back(temp);
                        }
                        LetterCount = 0;
                        CharacterFlag = 0;
                    }
                    else if (!Is_Letter(c) && !Is_Number(c) && !(LetterCount >= 3))
                    {
                        LetterCount = 0;
                        CharacterFlag = 0;
                    }
                    else if (Is_Number(c) && !(LetterCount >= 3))
                    {
                        LetterCount = 0;
                        CharacterFlag = 0;
                    }
                }
                in.close();
            }
            if (flag == 2)
            {
                ifstream in(FullPathName);
                char c;
                int CharacterFlag = 0;
                int LetterCount = 0;
                int WordNum = 0;
                char Letter1[LEN];
                char Letter2[LEN];
                int i;
                two temp;
                while (!in.eof())
                {
                    c = in.get();
                    if (WordNum == 0)
                    {
                        if (Is_Letter(c)) { Letter1[LetterCount] = c; LetterCount++; }
                        else if (Is_Number(c) && LetterCount >= 3)  {
                            CharacterFlag = 1;
                            Letter1[LetterCount] = c; LetterCount++;
                        }
                        else if (Is_Number(c) && !(LetterCount >= 3))
                        {
                            LetterCount = 0;
                            CharacterFlag = 0;
                        }
                        else if (!Is_Letter(c) && !Is_Number(c))
                        {
                            if (!(LetterCount >= 3)) {
                                LetterCount = 0;
                                CharacterFlag = 0;
                            }
                            else if (LetterCount >= 3 && c == ' ')
                            {
                                Letter1[LetterCount] = '';
                                LetterCount = 0;
                                CharacterFlag = 0;
                                WordNum = 1;
                            }
                            else {
                                LetterCount = 0;
                                CharacterFlag = 0;
                                WordNum = 0;
                            }
                        }
                    }
                    else if (WordNum == 1)
                    {
                        if (Is_Letter(c)) { Letter2[LetterCount] = c; LetterCount++; }
                        else if (Is_Number(c) && LetterCount >= 3)  {
                            CharacterFlag = 1;
                            Letter2[LetterCount] = c; LetterCount++;
                        }
                        else if (Is_Number(c) && !(LetterCount >= 3))
                        {
                            LetterCount = 0;
                            CharacterFlag = 0;
                            WordNum = 0;
                        }
                        else if (!Is_Letter(c) && !Is_Number(c))
                        {
                            if (!(LetterCount >= 3))
                            {
                                LetterCount = 0;
                                CharacterFlag = 0;
                                WordNum = 0;
                            }
                            else if (LetterCount >= 3)
                            {
                                Letter2[LetterCount] = '';
                                for (i = 0; i < int((*key2).size()); i++)
                                {
                                    if (Is_OneWord(Letter1, (*key2)[i].word1) &&
                                        Is_OneWord(Letter2, (*key2)[i].word2))
                                    {
                                        if (Letter1 < (*key2)[i].word1 || (Letter1 == (*key2)[i].word1&&
                                            Letter2 < (*key2)[i].word2))
                                        {
                                            (*key2)[i].word1 = Letter1; (*key2)[i].word2 = Letter2;
                                        }
                                        (*key2)[i].num++; break;
                                    }
                                }
                                if ((*key2).size() == 0 || i == (*key2).size()) 
                                {
                                    temp.word1 = Letter1; temp.word2 = Letter2; temp.num = 1;
                                    (*key2).push_back(temp);
                                }
                                LetterCount = 0;
                                CharacterFlag = 0;
                                WordNum = 0;
                                if (c == ' ')
                                {
                                    strcpy_s(Letter1, Letter2);
                                    WordNum = 1;
                                }
                            }
                        }
                    }
                }
                in.close();
            }
            if (flag == 3) 
            {
                ifstream in(FullPathName);
                char c;
                int CharacterFlag = 0;
                int LetterCount = 0;
                int WordNum = 0;
                char Letter1[LEN];
                char Letter2[LEN];
                char Letter3[LEN];
                int i;
                three temp;
                while (!in.eof())
                {
                    c = in.get();
                    if (WordNum == 0)
                    {
                        if (Is_Letter(c)) { Letter1[LetterCount] = c; LetterCount++; }
                        else if (Is_Number(c) && LetterCount >= 3)  
                        {
                            CharacterFlag = 1;
                            Letter1[LetterCount] = c; LetterCount++;
                        }
                        else if (Is_Number(c) && !(LetterCount >= 3))
                        {
                            LetterCount = 0;
                            CharacterFlag = 0;
                            WordNum = 0;
                        }
                        else if (!Is_Letter(c) && !Is_Number(c))
                        {
                            if (!(LetterCount >= 3))
                            {
                                LetterCount = 0;
                                CharacterFlag = 0;
                                WordNum = 0;
                            }
                            else if (LetterCount >= 3)
                            {
                                WordNum = 0;
                                if (c == ' ')
                                {
                                    Letter1[LetterCount] = '';
                                    WordNum = 1;
                                }
                                LetterCount = 0;
                                CharacterFlag = 0;
                            }
                        }
                    }
                    else if (WordNum == 1)
                    {
                        if (Is_Letter(c)) { Letter2[LetterCount] = c; LetterCount++; }
                        else if (Is_Number(c) && LetterCount >= 3)
                        {
                            CharacterFlag = 1;
                            Letter2[LetterCount] = c; LetterCount++;
                        }
                        else if (Is_Number(c) && !(LetterCount >= 3))
                        {
                            LetterCount = 0;
                            CharacterFlag = 0;
                            WordNum = 0;
                        }
                        else if (!Is_Letter(c) && !Is_Number(c))
                        {
                            if (!(LetterCount >= 3))
                            {
                                LetterCount = 0;
                                CharacterFlag = 0;
                                WordNum = 0;
                            }
                            else if (LetterCount >= 3)
                            {
                                Letter2[LetterCount] = '';
                                LetterCount = 0;
                                CharacterFlag = 0;
                                WordNum = 0;
                                if (c == ' ')
                                {
                                    WordNum = 2;
                                }
                            }
                        }
                    }
                    else if (WordNum == 2)
                    {
                        if (Is_Letter(c)) { Letter3[LetterCount] = c; LetterCount++; }
                        else if (Is_Number(c) && LetterCount >= 3) 
                        {
                            CharacterFlag = 1;
                            Letter3[LetterCount] = c; LetterCount++;
                        }
                        else if (Is_Number(c) && !(LetterCount >= 3))
                        {
                            LetterCount = 0;
                            CharacterFlag = 0;
                            WordNum = 0;
                        }
                        else if (!Is_Letter(c) && !Is_Number(c) )
                        {
                            if (!(LetterCount >= 3))
                            {
                                LetterCount = 0;
                                CharacterFlag = 0;
                                WordNum = 0;
                            }
                            else if (LetterCount >= 3)
                            {
                                Letter3[LetterCount] = '';
                                for (i = 0; i < int((*key3).size()); i++)
                                {
                                    if (Is_OneWord(Letter1, (*key3)[i].word1) &&
                                        Is_OneWord(Letter2, (*key3)[i].word2) &&
                                        Is_OneWord(Letter3, (*key3)[i].word3))
                                    {
                                        if (Letter1 < (*key3)[i].word1 || (Letter1 == (*key3)[i].word1&&
                                            Letter2 < (*key3)[i].word2) || (Letter1 == (*key3)[i].word1 &&
                                            Letter2 == (*key3)[i].word2 && Letter3 < (*key3)[i].word3))
                                        {
                                            (*key3)[i].word1 = Letter1; (*key3)[i].word2 = Letter2;
                                            (*key3)[i].word3 = Letter3;
                                        }
                                        (*key3)[i].num++; break;
                                    }
                                }
                                if ((*key3).size() == 0 || i == (*key3).size()) {
                                    temp.word1 = Letter1; temp.word2 = Letter2; temp.word3 = Letter3;
                                    temp.num = 1;
                                    (*key3).push_back(temp);
                                }
                                LetterCount = 0;
                                CharacterFlag = 0;
                                WordNum = 0;
                                if (c == ' ')
                                {
                                    strcpy_s(Letter1, Letter2);
                                    strcpy_s(Letter2, Letter3);
                                    WordNum = 2;
                                }
                            }
                        }
                    }
                }
                in.close();
            }
        }
    }
    return 0;
}

int main(int argc, char* argv[])
{
    int flag=1;
    char path[LEN];
    if (argv[1] == "") return 0;
    vector<one> first;
    vector<two> second;
    vector<three> third;
    if (argv[1][0] == '-'&&argv[1][1] == 'e'&&argv[1][2] == '2')
    {
        flag = 2;
        DirectoryList(argv[2], flag, &first,&second,&third);
        Two_Output(&second);
    }
    else if (argv[1][0] == '-'&&argv[1][1] == 'e'&&argv[1][2] == '3')
    {
        flag = 3;
        DirectoryList(argv[2], flag, &first, &second, &third);
        Three_Output(&third);
    }
    else if(argc=2)
    {
        flag = 1;
        DirectoryList(argv[1], flag, &first, &second, &third);
        One_Output(&first);
    }
    return 0;
}