my code review

原代码：

package guying.view;

import java.awt.BorderLayout;
import java.awt.Checkbox;
import java.awt.CheckboxGroup;
import java.awt.EventQueue;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;

import javax.swing.DefaultComboBoxModel;
import javax.swing.JButton;
import javax.swing.JComboBox;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JOptionPane;
import javax.swing.JPanel;
import javax.swing.JPasswordField;
import javax.swing.JTextField;
import javax.swing.SwingConstants;
import javax.swing.border.EmptyBorder;

public class Jiemian extends JFrame {

    private JPanel contentPane;
    
    
        private JTextField username;
        private JTextField email;
        private JPasswordField password;
        private JLabel man;

        JLabel label = new JLabel("用户注册");
        CheckboxGroup sex = new CheckboxGroup();



    /**
     * Launch the application.
     */
    public static void main(String[] args) {
                    Jiemian frame = new Jiemian();
                    frame.setVisible(true);
    }

    /**
     * Create the frame.
     */
    public Jiemian() {
            setTitle("用户注册");
            setBounds(100, 100, 414, 336);
            getContentPane().setLayout(null);

            label.setBounds(177, 10, 54, 15);
            getContentPane().add(label);

            JLabel label_1 = new JLabel("用户名");
            label_1.setHorizontalAlignment(SwingConstants.CENTER);
            label_1.setBounds(74, 43, 54, 15);
            getContentPane().add(label_1);

            JLabel label_2 = new JLabel("性  别");
            label_2.setHorizontalAlignment(SwingConstants.CENTER);
            label_2.setBounds(74, 78, 54, 15);
            getContentPane().add(label_2);

            JLabel label_3 = new JLabel("邮  箱");
            label_3.setHorizontalAlignment(SwingConstants.CENTER);
            label_3.setBounds(74, 115, 54, 15);
            getContentPane().add(label_3);

            JLabel label_4 = new JLabel("密 码");
            label_4.setHorizontalAlignment(SwingConstants.CENTER);
            label_4.setBounds(74, 151, 54, 15);
            getContentPane().add(label_4);

            JLabel label_5 = new JLabel("爱  好");
            label_5.setHorizontalAlignment(SwingConstants.CENTER);
            label_5.setBounds(74, 182, 54, 15);
            getContentPane().add(label_5);

            Checkbox man = new Checkbox("男", true, sex);
            man.setBounds(146, 74, 54, 23);
            getContentPane().add(man);

            Checkbox woman = new Checkbox("女", false, sex);
            woman.setBounds(235, 74, 71, 23);
            getContentPane().add(woman);

            username = new JTextField();
            username.setBounds(145, 40, 161, 21);
            getContentPane().add(username);
            username.setColumns(10);

            email = new JTextField();
            email.setBounds(145, 112, 161, 21);
            getContentPane().add(email);
            email.setColumns(10);

            password = new JPasswordField();
            password.setBounds(145, 148, 161, 21);
            getContentPane().add(password);

            JLabel label_6 = new JLabel("4-6u4F4D");
            label_6.setBounds(316, 151, 54, 15);
            getContentPane().add(label_6);

            JComboBox comboBox = new JComboBox();
            comboBox.setModel(new DefaultComboBoxModel(new String[] { "运动", "音乐" }));
            comboBox.setToolTipText("");
            comboBox.setBounds(145, 179, 93, 21);
            getContentPane().add(comboBox);
            JButton button = new JButton("清空");
            button.addActionListener(new ActionListener() {
                public void actionPerformed(ActionEvent arg0) {
                    username.setText("");
                    email.setText("");
                    password.setText("");
                }
        });
            button.setBounds(100, 251, 93, 23);
            getContentPane().add(button);

            JButton button_1 = new JButton("提交");
            button_1.addActionListener(new ActionListener() {
                public void actionPerformed(ActionEvent arg0) {
                    String name1 = username.getText();
                    String password1 = new String(password.getPassword());
                    String mail = email.getText();
                    String role1 = (String) comboBox.getSelectedItem();
                    String xb = null;
                    if (man.getState() == true) {
                        xb = "男";
                    } else {
                        xb = "女";
                }

                    if (name1 == null || name1.length() <= 0 || password1 == null || password1.length() <= 0
                            || role1 == null || role1.length() <= 0 || mail == null || mail.length() <= 0) {
                        JOptionPane.showMessageDialog(button_1, "请输入完整登入信息！");
                    } else if (mail != null && mail.length() > 0 && mail.indexOf('@') == -1
                            && mail.indexOf('.') <= mail.indexOf('@')) {
                        JOptionPane.showMessageDialog(button_1, "电子邮件输入错误！");
                    } else if (password1.length() < 4 || password1.length() > 6) {
                        JOptionPane.showMessageDialog(button_1, "密码不合规范！");
                    } else {
                        int n = JOptionPane.showConfirmDialog(null,
                                "用户名：" + name1 + "
" + "性别：" + xb + "
" + "电子邮件：" + mail + "
" + "爱好：" + role1, "选择一个选项",
                                JOptionPane.YES_NO_CANCEL_OPTION);

                        switch (n) {
                    case 0:
                            JOptionPane.showMessageDialog(button_1,
                                    "用户名：" + name1 + "
" + "性别：" + xb + "
" + "电子邮件：" + mail + "
" + "爱好：" + role1);
                        }
            }

                }
            });
            button_1.setBounds(253, 251, 93, 23);
            getContentPane().add(button_1);

        }
    }
    

修改意见：

1.代码不符合编程规范，大括号位置不对，行的长度、缩进也不对

2.代码没有尽可能的模块化，很零散

3.不是所有的代码都简单易懂，有些自己定义的变量的名称随便瞎取名字，别人看不懂