-
[Mise] Questions to Ask Yourself When Conducting a Code Review
Is the code clean and modular?
- Can I understand the code easily?
- Does it use meaningful names and whitespace?
- Is there duplicated code?
- Can you provide another layer of abstraction?
- Is each function and module necessary?
- Is each function or module too long?
Is the code efficient?
- Are there loops or other steps we can vectorize?
- Can we use better data structures to optimize any steps?
- Can we shorten the number of calculations needed for any steps?
- Can we use generators or multiprocessing to optimize any steps?
Is documentation effective?
- Are in-line comments concise and meaningful?
- Is there complex code that's missing documentation?
- Do function use effective docstrings?
- Is the necessary project documentation provided?
Is the code well tested?
- Does the code high test coverage?
- Do tests check for interesting cases?
- Are the tests readable?
- Can the tests be made more efficient?
Is the logging effective?
- Are log messages clear, concise, and professional?
- Do they include all relevant and useful information?
- Do they use the appropriate logging level?
-
相关阅读:
类加载机制
PTA(BasicLevel)-1094 谷歌的招聘
PTA(BasicLevel)-1023 组个最小数
异构图神经网络笔记-Heterogeneous Graph Neural Network(KDD19)
PTA(BasicLevel)-1014 福尔摩斯的约会
PTA(BasicLevel)-1013 数素数
PTA(BasicLevel)-1012 数字分类
PTA(BasicLevel)-1010 一元多项式求导
PTA(BasicLevel)-1009 说反话
PTA(BasicLevel)-1008数组元素循环右移问题
-
原文地址:https://www.cnblogs.com/Answer1215/p/12953765.html
Copyright © 2020-2023
润新知